Full support for null and non-null issue required properties in API#2659
Closed
labkey-jeckels wants to merge 3 commits intodevelopfrom
Closed
Full support for null and non-null issue required properties in API#2659labkey-jeckels wants to merge 3 commits intodevelopfrom
labkey-jeckels wants to merge 3 commits intodevelopfrom
Conversation
Contributor
Author
|
@labkey-klum as a repro case, here's a wiki I created to bulk resolve/close issues. It operates on the selected issues from the grid view. It failed on labkey.org due to problems with required custom fields. Repro steps: https://www.labkey.org/home/Developer/issues/wiki-page.view?name=Bulk%20Issue%20Resolver
|
labkey-klum
requested changes
Sep 2, 2025
Contributor
labkey-klum
left a comment
labkey-klum
left a comment
There was a problem hiding this comment.
It looks like your platform changes are breaking the IssueAPITest. The test appears to be relying on the previous behavior where null values were being ignored during validation.
The helper method : basicIssueModel probably shouldn't be used much in the update case.
Contributor
Author
|
Sure enough. Updates pushed. I will likely need to retarget to 25.9 but let's see what TC thinks first. |
labkey-klum
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We haven't been properly handling nulls in issue API calls for custom fields, especially when they're required.
Related Pull Requests
Changes